lib:ldb: Use correct integer types for sizes
commitd650f884ec1be0745af93020366b9e115670b771
authorAndreas Schneider <asn@samba.org>
Tue, 30 Apr 2024 12:33:51 +0000 (30 14:33 +0200)
committerVolker Lendecke <vl@samba.org>
Tue, 30 Apr 2024 15:33:32 +0000 (30 15:33 +0000)
treeea671c8512b67bed1941d73e93723cf9b7a8a493
parent17dd13bb4bc9bd38f663c376ee73de6598715da7
lib:ldb: Use correct integer types for sizes

Error: INTEGER_OVERFLOW (CWE-190):
ldb-2.9.0/common/ldb_ldif.c:84: tainted_data_return: Called function "read(f, buf, size)", and a possible return value may be less than zero.
ldb-2.9.0/common/ldb_ldif.c:84: cast_overflow: An assign that casts to a different type, which might trigger an overflow.
ldb-2.9.0/common/ldb_ldif.c:92: overflow: The expression "size" is considered to have possibly overflowed.
ldb-2.9.0/common/ldb_ldif.c:84: overflow_sink: "size", which might be negative, is passed to "read(f, buf, size)". [Note: The source code implementation of the function has been overridden by a builtin model.]
    82|           buf = (char *)value->data;
    83|           while (count < statbuf.st_size) {
    84|->                 bytes = read(f, buf, size);
    85|                   if (bytes == -1) {
    86|                           talloc_free(value->data);

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Apr 30 15:33:32 UTC 2024 on atb-devel-224
lib/ldb/common/ldb_ldif.c